Apply floor truncation on Digitizer output by default. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Digizer output fractional ADC values on the assumption that truncation was performed by subsequent file sink. As we now start to hook up NF+SP directly to sim, this truncation was being omitted leading to small discrepencies. Thanks @weihythu and Ewerton for finding this! The "round" option still supported with same default being false. This commit also does some temporary fixes some of the tests and leaves the tenio test failing. This is due to ongoing work in the apply-pointcloud branch. It requires recent wire-cell-python to be installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Digizer output fractional ADC values on the assumption that truncation was performed by subsequent file sink. As we now start to hook up NF+SP directly to sim, this truncation was being omitted leading to small discrepencies. Thanks @weihythu and Ewerton for finding this!
The "round" option still supported with same default being false.
This commit also does some temporary fixes some of the tests and leaves the tenio test failing. This is due to ongoing work in the apply-pointcloud branch. It requires recent wire-cell-python to be installed.